SamagraX-Stencil / stencil-cli

NestJS CLI on steroids for stencil 🍹
https://stencil.samagra.io/cli/introduction
Other
3 stars 9 forks source link

fix: fixed over-writing of gitignore file #17

Closed Savio629 closed 3 months ago

Savio629 commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x} Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Savio629 commented 3 months ago

// @techsavvyash @sooraj1002

Savio629 commented 3 months ago

// @sooraj1002

sooraj1002 commented 3 months ago

@Savio629 we need to add .env to the default .gitignore. after your change, that is not present as npx prisma init adds that to the gitignore and we are overwriting it

Savio629 commented 3 months ago

so we need to merge the .gitignore instead of replacing it? or should I just add .env under our default .gitignore file ?

sooraj1002 commented 3 months ago

you can just add to the default .gitignore

Savio629 commented 3 months ago

// @sooraj1002

sooraj1002 commented 3 months ago

looks good