FIX: image not loading - Githubissues

SamagraX-Stencil / stencil-web

Web molecules and pages

https://stencil-ui-templates.vercel.app/

8 stars 28 forks source link

FIX: image not loading #100

Closed soumya-maheshwari closed 2 months ago

soumya-maheshwari commented 2 months ago

Closes #70

Hi team,

I've reviewed the downtime page and identified an issue with the missing image. Upon further investigation, it seems that the image is not being rendered correctly on the page.

To address this issue, I've made the following changes:

Added Image Component: I've added the necessary code to render the image component on the downtime page.
Verified Integration: I've tested the page locally to ensure that the image is now being displayed correctly.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ui-templates	✅ Ready (Inspect)	Visit Preview	Apr 26, 2024 2:23pm

biratdatta commented 2 months ago

Hey, @soumya-maheshwari I checked your Deployed link generated for your PR . Here I can't see the Image showing on the screen. Can you look into it again?

Happy to help if you have further questions.

soumya-maheshwari commented 2 months ago

questions

sure I'll check it once and will let you know.

soumya-maheshwari commented 2 months ago

hello @biratdatta

on local host it's working fine and the image is also showing can u please help where could be the problem.

biratdatta commented 2 months ago

Hey, you can check the app.config.json file and find out the config for the downtime page and in that add the source path of the image and check if it is coming during the deployment or not. Try this one out and debug the issue and resolve ur merge conflict issue for your PR.

soumya-maheshwari commented 2 months ago

hi @biratdatta i have changed the config for the downtime page in the app.config.json file and resolved the merge conflict issue for my PR. can you please check it once.

i think we should provide the URLof image here like it is present in other parts

biratdatta commented 2 months ago

Hey @soumya-maheshwari , can you debug the problem on why it is happening because the Launch Page image is also rendering from the assets.

soumya-maheshwari commented 2 months ago

Hello @biratdatta i have made some changes in the downtime page can you please check it now it is rendering in the deployment site as well.

prtkjakhar commented 2 months ago

Issue fixed by another PR