Open shivankurchavan opened 4 months ago
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The pdf service is generating pdf on basis of given template.html
and data.csv
It is working similar to fileupload service
The issue is if the data is huge then it can reach the limit
{
"statuscode": 201,
"data": [
{
"data": {
"message": {
"statusCode": 500,
"message": "Certificate generation failed",
"errors": "Timed out after waiting 30000ms"
},
"statusCode": 201
},
"errors": []
}
]
}
Should we ask an optional timeout from the user as a query?
https://github.com/user-attachments/assets/a37dfc1d-5999-4193-94a4-64670e69e789
The certificate comes out to be something like this
@Savio629
In the response pasted in your comment it says 500 in data and 201 in statusCode why is that?
I feel the api req is being created/sent successfully which is why the statusCode is 201 but the response from the server is 500 as it timed out.
The photos are not getting rendered in the screenshot itself the screenshot field is broken -- shows that something is not correct and needs fixing.
I haven't sent the path of the photos to the server. Can you suggest some ways to do so? As i'm doing api request and a single image file won't be feasible and api doesn't accept a folder so should we sent a zip folder with assets?
Tried to implement https://svelte.dev/docs/svelte-compiler https://github.com/withastro/compiler but didn't received expected output Will try out this package out https://www.npmjs.com/package/svelte-to-html
What solution do you propose for solving the large data issue?
Where are we on the support for different templating engines? Even if not baked right into it have we structured the code in such a way that expansion to more template formats is very configurable?
Where are we on the queuing part of things?
Have you worked on an internal PDF churner service which is to be used incase the user does not want to use Gotenburg as discussed with Chakshu during the last weekly review call?
index.html
which won't be feasible for us. https://gotenberg.dev/docs/6.x/html
// @shivankurchavan How have we solved for errors in PDF generation like headers and footers getting cut? This problem was discussed during the standups itself when this service was being discussed.
There are no errors in headers and footers at the moment.
The photos are not getting rendered in the screenshot itself the screenshot field is broken -- shows that something is not correct and needs fixing.
Fixed the issue in the latest commit
In the response pasted in your comment it says 500 in data and 201 in statusCode why is that?
We were sending the response with 500 instead forgot to throw an error there. Will look into it
Draft PR
till now :
https://github.com/SamagraX-Stencil/stencil/assets/61339210/a5cd9b8b-2825-4414-b5de-e6d9eccf0fa6