Samantha-Mcguigan / newsAnalysis

repository for our newsAnalysis web page
3 stars 0 forks source link

Final Tasks #18

Closed Samantha-Mcguigan closed 6 years ago

Samantha-Mcguigan commented 7 years ago
Samantha-Mcguigan commented 7 years ago

Nevermind @ajnewton1 in the CSS the bottom was set as fixed instead of relative!

Samantha-Mcguigan commented 7 years ago

@jonhoranic @ajnewton1 Would you two want to put conclusions under the Methodology page or create a new page? I was thinking we could create a new issue and edit it together or if you want to meet, I can do between 3 and 6.

jonhoranic commented 7 years ago

@Samantha-Mcguigan I think removing that bottom paragraph at the bottom of the homepage (or moving it to methodology) and putting our conclusions in short there would tie up everything there on the homepage at a glance, then the reader could click around to see for themselves.

Samantha-Mcguigan commented 7 years ago

@jonhoranic @ajnewton1 okay, Im going to go ahead and move that.

Samantha-Mcguigan commented 7 years ago

@jonhoranic @ajnewton so are we meeting today or just creating a new issue for conclusions?

dotfig commented 7 years ago

@Samantha-Mcguigan @jonhoranic I can meet today. I have a final at 3:15 so hopefully I will be out by 4. But if no one is around then we can just make an issue

jonhoranic commented 7 years ago

@Samantha-Mcguigan @ajnewton1 I am unfortunately sick as a dog, a recent flare up this morning prevented me from making it to the college. I am doing what I can, I can work from an issues board if need be, let me know. I will be working on the write up content soon, let me know if there are any descriptions you think we should add.

jonhoranic commented 7 years ago

@Samantha-Mcguigan @ajnewton1 I am almost done with the last few edits of the site info, the files as pushed can go right up on the site but please look them over just to make sure we agree on everything written.

jonhoranic commented 7 years ago

@Samantha-Mcguigan @ajnewton1 All spelling/grammar is checked, I am moving on to link problems for the moment. Let me know if there is anything else I am missing.

EDIT: Not seeing any issues with the links on my end, each one in the hyperlink element works.

Samantha-Mcguigan commented 7 years ago

@jonhoranic @ajnewton1 are either one of you going to add to the conclusions paragraph? If not I'm just going to put it up as is. @jonhoranic are you going to turn the project in?

Samantha-Mcguigan commented 7 years ago

@jonhoranic @ajnewton1 I went ahead and pushed the conclusions to the index page, feel free to change it. @jonhoranic since you are our fearless leader I'm going to leave it to you to create the final issue letting Dr. B and Becca know our site is ready for grading.

jonhoranic commented 7 years ago

@Samantha-Mcguigan Sorry for not seeing this last night, I am putting up an issue now. I will ping @ajnewton1 and everyone else from it.