Closed tejus0 closed 2 years ago
@tejus0 Assinged
Hey @SamarthTMSL I have made your Guests Card slider automatic so should I remove Arrows or the buttons below the slider ? Or is it fine ? And it is stopping when user hovers on a Guest . So is it Ok or i should make i infinite loop and never stop .
Yes Sure make the loop infinite and buttons/arrows are not needed if the cards can me manually swiped also. Also please implement the same thing in our teams page and make a pr @tejus0
Hey @SamarthTMSL I have made the sliders with infinite loops and removed arrows but if someone want then user can also access particular guest using one click on buttons below the cards . But tell me about the teams page as it is not visible in your website . But when i open team.html my slider works fine . So i guess my changes have applied to teams page also . Additionally i have added red color to corners of each card which looks good . So review my changes in PR.
We have reviewed the changes @tejus0
@SamarthTMSL Have you merged it under hacktoberfest label? As it is not reflecting in my progress.
The UI of Guest card is somewhat bigger in size for mobile viewers. This the arrows created to slide the different guests can not be used effectively or very difficult to click on the arrow buttons due to their small size. The guests card can be made automatic slider with a time counter so that different guests can be shown on a particular time interval. So i request @SamarthTMSL to assign me this issue so that i can make your designer website more functional.