SamarthTech / Samarth-Website

The old website of Samarth TMSL.
https://samarthtech.github.io/Samarth-Website/
MIT License
25 stars 39 forks source link

fix get in touch btn #52

Closed vivianemartini closed 1 year ago

vivianemartini commented 1 year ago

Hi there, right now the button on the banner is now working properly, is no showind the hover and is not clickable. pls assign this ticket so that i wont loose the count on it Thank you:)

SamarthTech commented 1 year ago

Please refer with a screenshot

vivianemartini commented 1 year ago

showing hover issue

SamarthTech commented 1 year ago

But it is working correctly

Hiresh23 commented 1 year ago

i would like to contribute to issue ,please assign

Hiresh23 commented 1 year ago

can you please assign it with hacktoberfest tag

vivianemartini commented 1 year ago

hey @SamarthTMSL, I made a new video, when I inspected the hover was appering, so the hover and clickable behaviour should be visible only when the browser is resized?

Cause if that's the case I would suggest to remove the button from the hero banner because it gives the user the idea of been clickable, this would improve the website user experience.

if this is the case, I"d like to work on that for hacktoberfest

SamarthTech commented 1 year ago

Screenshot (24)

We checked again found that the button is not working in some scenarios because the section underneath that is overlapping with the button. We want the button to be there. Can you fix that @vivianemartini @Hiresh23 ?

vivianemartini commented 1 year ago

yes I can, can you assign to me?

Meghadri-Koley commented 1 year ago

@vivianemartini Assigned

vivianemartini commented 1 year ago

Hi @Meghadri-Koley, I've submited my PR, in case of acceptance, could you add the label for hacktoberfest-accepted into the issue? have a good one

Sabyasachi-Seal commented 1 year ago

Tag Added and PR Merged .