github-actions[bot]
commented
2 years ago | Warnings | |
|---|---|
| :warning: | Sources/DiceKit/Enums.swift was changed, but there is no file at path Tests/DiceKitTests/EnumsTests.swift. Maybe it's under a different path, or maybe there are no tests |
| :warning: | Sources/DiceKit/Utilities.swift was changed, but there is no file at path Tests/DiceKitTests/UtilitiesTests.swift. Maybe it's under a different path, or maybe there are no tests |
| Messages | |
|---|---|
| :book: | Non-new version PR detected, to branch master |
| :book: | Internal PR detected |
| :book: | The CHANGELOG was updated |
| :book: | Sources/DiceKit/Rollable.swift has had corresponding changes in its test file |
| :book: | An XCTestManifests file was updated, but make sure it has ALL the new tests |
| :book: | PR has no tasks (are you sure?) |
Generated by :no_entry_sign: Danger Swift against f17cb73826d9e719044adca22ff527ed156f6405
This makes
Rollable.roll(times:_:)a throwing function, in addition to adding a new error case and a suite of tests for the function. Since this changes the function signature, it is a breaking change, but since we are still pre-1.0.0, this is fine.