Samasaur1 / DiceKit

A Swift module for simulating dice both real and unreal
https://samasaur1.github.io/DiceKit/
Academic Free License v3.0
4 stars 4 forks source link

Danger should not tell PR authors to put changes in the Upcoming section of the changelog if it is a new version PR #105

Open Samasaur1 opened 2 years ago

Samasaur1 commented 2 years ago

When making a PR to master that is not a new version, if the author has not yet updated the CHANGELOG, Danger will tell them to "Put your changes in the UPCOMING section". This is what we want. However, this same message is outputted even if the PR is for a new version (in which case everything in the UPCOMING section, along with any new information, should be under a version heading).

Here's the part of the Dangerfile that controls this output:

https://github.com/Samasaur1/DiceKit/blob/b91141b2b5bc254e98011a52c027fac8ac1199be/Dangerfile.swift#L92-L101

We should put these CHANGELOG checks inside the if-else statement checking new versions, in order to give more useful output.