trimming flags conditioned on net6.0 or better

SamboyCoding / Cpp2IL

Work-in-progress tool to reverse unity's IL2CPP toolchain.

MIT License

1.68k stars 197 forks source link

trimming flags conditioned on net6.0 or better #242

Closed mitchcapper closed 9 months ago

mitchcapper commented 9 months ago

fix build failures when it tries to build with .net framework compat.

SamboyCoding commented 9 months ago

Not sure why this is necessary when you can just build with modern msbuild and /p:TargetFramework=net472 like the CI does

mitchcapper commented 9 months ago

I don't know, actually it was the CI that was failing, https://github.com/mitchcapper/Cpp2IL/actions/runs/7225981068 my GH just isn't as good as your GH:) I am guessing some environment variable but I saw the errors and figured conditioning it was the easiest fix.

SamboyCoding commented 9 months ago

Interesting ok, that looks like it might have been a breaking change in net8's msbuild.

mitchcapper commented 9 months ago

I have noticed .net8 is much more strict on things that previously worked