LibCpp2IL: Return empty array if number of read elements is 0 - Githubissues

SamboyCoding / Cpp2IL

Work-in-progress tool to reverse unity's IL2CPP toolchain.

MIT License

1.68k stars 197 forks source link

LibCpp2IL: Return empty array if number of read elements is 0 #345

Closed commonuserlol closed 5 days ago

commonuserlol commented 6 days ago

If length is 0, indexing array at 1 is an exception https://github.com/SamboyCoding/Cpp2IL/blob/2f8e5b3fcbdefaf4b851d4234ede44f6c4138efa/LibCpp2IL/Metadata/Il2CppMetadata.cs#L322

Fixes https://github.com/SamboyCoding/Cpp2IL/issues/342

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 11084184650

Details

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 28.388%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
LibCpp2IL/Metadata/Il2CppMetadata.cs	1	2	50.0%
<!--	Total:	1	2	50.0%	-->

Totals
Change from base Build 11023494789:	0.005%
Covered Lines:	3342
Relevant Lines:	10041

💛 - Coveralls