Sambruk / EgilSCIM

The EGIL SCIM client
GNU Affero General Public License v3.0
4 stars 7 forks source link

Unhelpful error message when a StudentGroups is missing its relation to the SchoolUnit #130

Closed joesiltberg closed 2 years ago

joesiltberg commented 2 years ago

Typically if we can't establish a relation between a StudentGroup and its SchoolUnit (perhaps the school unit code attribute is missing for the group), we get an error like this:

Failed to create relational object: Activity some relation is missing it's GUID

We should improve this message so it actually gives the user a clue about what the problem it. At least print out the group UUID if available (and perhaps simply print out a suggestion that the problem might be that the group isn't connected to its schoolunit).

We could also give better messages if we could mark a relation as required. Every group should have a relation to a school unit, so the user could configure that relation as "required", which would give the client a better chance at informing the user of what went wrong.