search

SameerDalal / QuantumGo_Engine

GNU Affero General Public License v3.0
0 stars 1 forks source link

score calculation question #5

Open benjaminpjones opened 3 months ago

benjaminpjones commented 3 months ago

https://github.com/SameerDalal/QuantumGo_Engine/blob/b26b9ab8b45bb44d6c5ea701efdacb32814bc734/local_simulator.py#L75

Is this right? I am not familiar with a Go ruleset that just depends on Black's captures and komi.

For reference, the govariants.com implementation:

SameerDalal commented 3 months ago

I believe that code is not right. I do have copilot that completes some of the code, so it must've slipped my mind. Coincidentally, all my test cases were accurate.

Thank you for pointing that out

benjaminpjones commented 3 months ago

Thanks for the confirmation!

Coincidentally, all my test cases were accurate.

I should have asked earlier - are there unit tests in the repo? I looked around and didn't see any. Included a new test directory in my recent PR (#7), but I can move it if there is an established test location.

SameerDalal commented 3 months ago

I was actually testing the functions manually since I needed to pre-process some of the SGF data, but having built in tests would be much easier. I will take a look!