search

Samfox2 / homebridge-videodoorbell

Video-Doorbell plugin based on homebridge-camera-ffmpeg for Homebridge.
Apache License 2.0
97 stars 17 forks source link

Fixed multi-cam initialization #13

Closed normen closed 6 years ago

normen commented 6 years ago

This PR fixes multiple camera initialization, the http server was generated multiple times as the whole configuration was pushed multiple times.

It also adds a throttle of 10s to the event firing so that the message is only sent once every 10 seconds (by default).

Plus the parameters all have default values now.

The "port" parameter is back in the global settings as I think it makes more sense there.

normen commented 6 years ago

Come to think of it, I have some more ideas for this plugin so if you don't want to develop it further I could pick up if you want. But of course we can continue to work with PRs as well - or not at all if you don't want :)

I'm thinking about adding other features, for example a switch for the camera directly in HomeKit so you can link it with other switches so that when they're pressed an image message is sent.

Samfox2 commented 6 years ago

Thank you for your contribution. Multi cam init was on my list but who has more than one door cam :-)

normen commented 6 years ago

Well I do :) I'll look into adding the "switch" feature as well, for me its much more convenient to simply link the bell with my actual 433mHz doorbell via a HomeKit automation.

Samfox2 commented 6 years ago

Sounds great. By the way - I‘m getting a lot of questions about a compiled ffmpeg binary for raspi 3 (guess it‘s your thing). Could you upload your binary and link it in the readme (here and maybe also in KhaosT‘s plugin - I‘m sure he gets the same questions). Thx.

normen commented 6 years ago

No, thats illegal. I added info on how to compile to the original plugins wiki, the link is actually in your README :)

Samfox2 commented 6 years ago

Ok, actually it is not but I will continue to refer to it.

normen commented 6 years ago

Ah, true, they solved the licensing issues. Anyway not interested in hosting or supporting a binary in any form :)