search

Samgisaninja / unc0ver-localizations

Translations of the unc0ver jailbreak
53 stars 117 forks source link

Duplicate Ukrainian translation #83

Open 0x9fff00 opened 5 years ago

0x9fff00 commented 5 years ago

There are currently two Ukrainian translations in this project:

ua-UA.lproj should either be removed or merged into uk-UA.lproj.

badger-ua commented 5 years ago

Yeah, that’s true, ua-UA is incorrect. PS: I’m opened for improvements if I did translate something incorrectly.

sage444 commented 5 years ago

Hey guys

I’m aware of that typo and workings on merge of two variants of translation

On Wed, Aug 28, 2019 at 6:42 PM Yurii Yesipov notifications@github.com wrote:

Yeah, that’s true, ua-UA is incorrect.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Samgisaninja/unc0ver-localizations/issues/83?email_source=notifications&email_token=AATD6CUNWGGN3MRAMGOFZETQG2MEXA5CNFSM4IRKP3LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LR3RA#issuecomment-525802948, or mute the thread https://github.com/notifications/unsubscribe-auth/AATD6CQWIR6K7WK3U7TXQPDQG2MEXANCNFSM4IRKP3LA .

Samgisaninja commented 5 years ago

so remove ua-UA or wait for sage to merge? or both?

sage444 commented 5 years ago

@Samgisaninja I finished merge and submitted PR #85 (where ua-UA is removed) We still in discussion about right translation of some words but in general translation is ready to use. Can you confirm @yyesi ?

badger-ua commented 5 years ago

@sage444 yeah, it's definitely better now

Samgisaninja commented 5 years ago

Y'all good to merge or want more time?

sage444 commented 5 years ago

I vote for merge now.

badger-ua commented 5 years ago

I vote for merge now.

Fine by me.