search

SamiPerttu / fundsp

Library for audio processing and synthesis
Apache License 2.0
800 stars 43 forks source link

Update wave.rs #31

Closed chanq-io closed 1 year ago

chanq-io commented 1 year ago

Previous implementation was sampling from the start of the waveform, which causes a discontinuity. This is particularly obvious when you use it in conjunction with fade_in or simply fade.

Before fix: gen

After fix: gen

(FYI I just quickly copied some of the plotting code so the legend is nonsense)

SamiPerttu commented 1 year ago

Thanks for the fix! I'm releasing the next version soon.

chanq-io commented 1 year ago

No problem! Thanks for making such an awesome lib. Would love to get more involved. Do you have a backlog I can contribute to when I have time?

SamiPerttu commented 1 year ago

Splendid! I made FUTURE.md with some ideas, check it out, maybe one of them strikes your fancy.