Samik081 / beets-beatport4

Beatport API v4 compatible beets plugin
MIT License
26 stars 2 forks source link

100 Tracks release not recognized #9

Closed JOJ0 closed 1 year ago

JOJ0 commented 1 year ago

Hi, it seems a large release isn't recognized as such:

Various Artists - Tech-house Sessions
  ≠ tracks, year
  Beatport | Digital | 2012 | Bavaria Recordings | 10031448
  https://beatport.com/release/tech-house-sessions/858337
  * Artist: 
  ≠ Album: Tech-House Sessions -> Tech-house Sessions
     ≠ (#81) Antidote (Morgan Tomas Remix) (9:39) -> (#5) Institution (Ingo Boss Remix) (8:22)
Missing tracks (9/10 - 90.0%):
 ! I Wanna Funk (Chube.ka Darkside Remix) (#1) (6:54)
 ! Phunky Tonner (Remix) (#2) (8:00)
 ! Comme Ci Comme Ca (Alex Dolby Remix) (#3) (7:41)
 ! Tulpenbluete (Andre Kronert Remix) (#4) (8:54)
 ! Duetto (Damolh33 Remix) (#6) (6:11)
 ! Janet (#7) (5:26)
 ! Wormhole (Original) (#8) (8:22)
 ! Pferd (#9) (7:55)
 ! Brothers And Sisters (Ron Ractive Edit) (#10) (7:12)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, plaY, eDit, edit Candidates? 

The release "Tech-house session" has 100 tracks on it, but the importer thinks it is only 10 tracks. The track Antidote (Morgan Tomas...) definitely is on that release when I look at the release link in the browser.

JOJ0 commented 1 year ago

Ah, there is another example:

  Match (68.0%):
  Various Artists - Kibou (Hope) (Disc 1)
  ≠ tracks
  Beatport | Digital | 2011 | Elektrax Music | ELEKMUS003A
  https://beatport.com/release/kibou-hope-disc-1/906809
  * Artist: 
  ≠ Album: Kibou (Hope) -Disc 1 -> Kibou (Hope) (Disc 1)
     ≠ (#11) Found (8:11) -> (#2) Parking 236 (7:46)
Missing tracks (9/10 - 90.0%):
 ! Flamingo (Kibou Edit) (#1) (5:39)
 ! The Process (#3) (5:12)
 ! Space Oddyssee feat. Coco (#4) (6:45)
 ! Blue Ice (#5) (6:54)
 ! G-Town Condolence Sequence (#6) (7:31)
 ! Lagrange (#7) (7:11)
 ! Deep Earth (#8) (8:38)
 ! J.C.C.T (#9) (6:55)
 ! Liquid Shape (#10) (6:45)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates, plaY? m

Finding tags for album "Truss, Donor - Kibou (Hope) - Disc 1".
  Candidates:
  1. (68.0%) Various Artists - Kibou (Hope) (Disc 1)
             ≠ tracks
             Beatport | Digital | 2011 | Elektrax Music | ELEKMUS003A
➜ # selection (default 1), Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates, plaY?  

Without having looked into the code, is it possible that there is a hard limit of 10 tracks per release?

Samik081 commented 1 year ago

Hey @JOJ0 thanks for spotting another one! Unfortunately, I couldn't recreate this issue, neither could I find anything during the debugging process that could cause this. I have managed to successfully import Various Artists - Kibou (Hope) (Disc 1) album with 2 tracks missing (actually missing).

Correcting tags from:
    Kibou (Hope)
To:
    Kibou (Hope) (Disc 1)
URL:
    https://beatport.com/release/kibou-hope-disc-1/906809
(Similarity: 97.7%) (tracks, album) (Beatport, Digital, 2011, Elektrax Music, ELEKMUS003A)
 * Flamingo - Kibou Edit ->
   Flamingo (Kibou Edit)
 * Parking 236
 * The Process
 * Blue Ice
 * G-Town Condolence Sequence
 * Lagrange
 * Deep Earth
 * J.C.C.T
 * Liquid Shape
 * Nippon Syndrome
 * Tears of Meiji - Echo Chamber Repaint ->
   Tears of Meiji (Echo Chamber Repaint)
 * Rockets
 * Fever
 * Beep Beep
 * Vex ->
   Vex feat. Rachel Haywire (artist, title)
 * Cameleon ->
   Cameleon (artist)
 * Stardust
 * El Sol
Missing tracks (2/20 - 10.0%):
 ! Space Oddyssee feat. Coco (# 4) (6:45)
 ! Found                     (#11) (8:11)
[A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort? B

Just to make sure, have you tried it on the v0.3.2 which has perPage parameter fixed? This bug could probably cause this issue.

JOJ0 commented 1 year ago

Oh maybe I forgot to upgrade. Will check. Thanks!!!

Samik081 commented 1 year ago

Hey @JOJ0, could you check if this issue still occurs on >=v.0.3.2?

JOJ0 commented 1 year ago

Hi, sorry for the delay. I reproduced the issue with v0.3.1 then checked out tag v0.3.2 and it definitely works! All 100 tracks of the mentioned release found. Was my bad, I had been using v0.3.1 back then still. Thanks!