Improve thumbnail look when using thumbfast

Samillion / ModernZ

A sleek and modern OSC for mpv designed to enhance functionality by adding more features, all while preserving the core standards of mpv's OSC.

GNU Lesser General Public License v2.1

27 stars 3 forks source link

Improve thumbnail look when using thumbfast #108

Closed Keith94 closed 3 hours ago

Keith94 commented 5 hours ago

The square corners on the thumbnail doesn't really match the rest of the UI, especially when using Windows 11, and the white border can also be a little distracting IMO.

Maybe it's better to change the radius and color of the border directly? Something like uosc's approach:

mpv_Uk5dvlaV5R

Samillion commented 4 hours ago

Bro, you're reading my mind 😆 I was literally just adding border color option, then saw you post this issue.

-- opts
thumbnailborder_color = "#111111",     -- color of border for thumbnail (with thumbfast)

--styles
thumbnail = "{\\blur1\\bord0.5\\1c&H" .. osc_color_convert(user_opts.thumbnailborder_color) .. "&\\3c&H000000&}",

Keith94 commented 4 hours ago

Lol that's amazing! Can't wait to see it in action. Hope you add rounded too.

Samillion commented 4 hours ago

I'm trying to think of how to implement rounded corners effectively, since that would mean we'd have to add options for thumbnail height/width within ModernZ itself, which ignores thumbfast's conf on that. I'm not sure how that would impact users.