search

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.
MIT License
56 stars 41 forks source link

Angular 7.x support #29

Closed Eraldo closed 5 years ago

Eraldo commented 5 years ago

I am using this package with angular 7.2.13. Judging from my perspective it does seem to work.

When I do npm i I get a warning: ngx-embed-video@1.0.4 requires a peer of @angular/core@^6.0.0

I am wondering why it is kept at @angular/core@^6.0.0. Any ideas?

SamirHodzic commented 5 years ago

To support 6.x+ versions, currently peerDependencies are defined as 6.0.0 min version. Probably will be updated soon to 7+.

Eraldo commented 5 years ago

Thank you @SamirHodzic for the update. I appreciate it. ;)