Updated Angular to v4.4.4

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.

MIT License

56 stars 41 forks source link

Closed hnipps closed 6 years ago

hnipps commented 6 years ago

Also changed tsconfig options to fix an error that arose - TS2304: Cannot find name 'Iterable'

hnipps commented 6 years ago

It's auto-generated by npm and is intended to be committed - https://docs.npmjs.com/files/package-lock.json

Do you still want me to remove it?

SamirHodzic commented 6 years ago

I know and you are right, but I found that it adds a lot of noise to diff so don't wanna to introduce it to this tiny plugin.

hnipps commented 6 years ago

Ok, no problem.

hnipps commented 6 years ago

I removed package-lock.json

SamirHodzic commented 6 years ago

Seems like your PR have conflicts now.

hnipps commented 6 years ago

Resolved.