search

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.
MIT License
56 stars 41 forks source link

Doesn't work with Typescript 2.6.2 or higher / Angular Package Format #7

Closed mwawrusch closed 6 years ago

mwawrusch commented 6 years ago

I'll get this

ERROR in ./node_modules/ngx-embed-video/index.ts
Module build failed: Error: ..../node_modules/ngx-embed-video/index.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).
    at AngularCompilerPlugin.getCompiledFile (/...../node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:677:23)
    at plugin.done.then (...../node_modules/@ngtools/webpack/src/loader.js:467:39)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
ERROR in ./node_modules/ngx-embed-video/src/embed-video.service.ts
Module build failed: Error:..../node_modules/ngx-embed-video/src/embed-video.service.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
**The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).**
    at AngularCompilerPlugin.getCompiledFile (/...../node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:677:23)
    at plugin.done.then (....../node_modules/@ngtools/webpack/src/loader.js:467:39)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
mwawrusch commented 6 years ago

That's what the error says:

Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv)

bostondevin commented 6 years ago

+1

rktvsiim commented 6 years ago

Same problem. Angular 5.2.4 and TypeScript 2.6.2

ghost commented 6 years ago

Same error in angular 6 while doing a production build. Works on dev. Please help

SamirHodzic commented 6 years ago

Should be fixed by https://github.com/SamirHodzic/ngx-embed-video/pull/16, let me know if problem still persist in Angular 6.

Moppet12 commented 6 years ago

I just updated to 1.0 but still facing this issue on ng build, my angular version is 5, any clue @SamirHodzic ?

SamirHodzic commented 6 years ago

@Moppet12 should work with Angular6+.