search

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.
MIT License
56 stars 41 forks source link

Bug with cordova (ionic) url protocol #9

Closed Nightbr closed 6 years ago

Nightbr commented 6 years ago

Hey,

I have an issue with the url protocol of video. In your code, you set url src="//www.youtube.com/embed/but in mobile app with cordova, the protocol is file:// so it throw an error...

I think today https is a requirement everywhere so we can just hardcoded src="https://www.youtube.com/embed/ in this lib.

If you're not agree with this, we can create a parameter to set the protocol manually and use it when it is set.

Let me know what do you want and I will create a PR ASAP.

image

Thanks!

SamirHodzic commented 6 years ago

Yes, https is kinda main for those video streaming services. Thanks, will check out PR. 👍

SamirHodzic commented 6 years ago

Closing per https://github.com/SamirHodzic/ngx-embed-video/pull/10.