search

SamirTalwar / smoke

Runs tests against anything, using command-line arguments, STDIN, STDOUT and STDERR.
MIT License
89 stars 10 forks source link

Smoke Github Action #92

Open jonaprieto opened 1 year ago

jonaprieto commented 1 year ago

Many projects living on Github could get the benefit of Smoke for testing in the CIs if there is an easy Smoke Github action. Maybe a starting point is: https://github.com/rwe/actions-hlint-run

https://docs.github.com/en/actions/creating-actions.

jonaprieto commented 1 year ago

The following could be used in a GitHub workflow to setup the binary smoke without further complications. Maybe consider including this in the README.

    - name: Download Smoke binary
        uses: jaxxstorm/action-install-gh-release@v1.9.0
        with:
          repo: SamirTalwar/smoke
          tag: v2.3.1
          cache: enable
          extension-matching: disable
          rename-to: smoke
          chmod: 0755
SamirTalwar commented 1 year ago

Looks good; please feel free to submit a PR.

jonaprieto commented 1 year ago

I'll do it tomorrow. Btw, can you please make a new release?

SamirTalwar commented 1 year ago

Yeah, I'd like to do that. However, the current code on main introduces a dependency on ICU4C, and I need to make sure that this doesn't break everything on various setups, so it requires more manual testing than usual. (If it does, I will need to figure out another approach to regular expressions.)