search

SammehFFXI / FFXIAddons

53 stars 114 forks source link

DistancePlus & HomePoint didnt work for me ; ; #7

Open Lithgen opened 7 years ago

SammehFFXI commented 6 years ago

Without a description I don't know how to help you. What didn't work about them? DP is very stable, to the point where Windower team adopted it (but they haven't gone from Dev to production yet so I keep it out here for people to use). HomePoint only issue I'm aware of is a rare case where npc lag(server side) can cause a lock on an invisible menu.

Sounds like you're not loading correctly.

-SAm

luffi101 commented 5 years ago

Hi Sam, I am getting this error lua runtime error: distanceplus/distanceplus.lua:160: attempt to perform arithmetic on field '?' (a nil value)

I run JP ff11 client, maybe there is some setting not compatible? Let me know if you need additional info.

Best

theTaikun commented 5 years ago

What was the command you entered to result in that error?

luffi101 commented 5 years ago

What was the command you entered to result in that error?

I notice the runtime error occurs only when I sj DNC.

theTaikun commented 5 years ago

What was the command you entered to result in that error?

I notice the runtime error occurs only when I sj DNC.

I mean did you type something into the console to get the runtime error or did it come up automatically after switching to /dnc?

F.Y.I, I'm not a maintainer of this project, but I'm looking to help resolve issues on any project that I can. I saw this one and recognized Sammeh's name from back in the day. Quetzalcoatl is my server too.

luffi101 commented 5 years ago

no input, the error just starts to flood the drop down console whenever I switch sj to DNC.

Thanks

theTaikun commented 5 years ago

Just looking at the file, I see where the problem might be at line 160, but when I get back to the states I'll try some testing

theTaikun commented 5 years ago

I tried different combinations of main job with /dnc, but I could not replicate this bug. Maybe it is due to your JP client, or maybe there's conflict with another mod

luffi101 commented 5 years ago

Thanks for taking the time to help :)

If I have new finding I will post again, thanks

shalock999 commented 1 year ago

the problem is at line 154 "ability_en = res.job_abilities[ability].name".

res.job_abilities[ability].name will return a japanese name at JP client but compare it with english name at line 158 "ability_en ~= "Flourishes II"" then get error at line 160 because range_mult[ability_distance] is a nil value. (the range value of Flourishes II is 0)

just modify line 154 to "ability_en = res.job_abilities[ability].en" work well at JP client but didn't try it at EN client :)

luffi101 commented 1 year ago

Thanks Sam! I have stopped playing for a while now, but I appreciate your response after so many years! luffi

Edward

From: shalock999 @.> Sent: Wednesday, September 6, 2023 8:18:04 PM To: SammehFFXI/FFXIAddons @.> Cc: luffi101 @.>; Comment @.> Subject: Re: [SammehFFXI/FFXIAddons] DistancePlus & HomePoint didnt work for me ; ; (#7)

CAUTION-EXTERNAL EMAIL: Do not click on links or open attachments from untrusted sources

the problem is at line 154 "ability_en = res.job_abilities[ability].name".

res.job_abilities[ability].name will return a japanese name at JP client but compare it with english name at line 158 "ability_en ~= "Flourishes II"" then get error at line 160 because range_mult[ability_distance] is a nil value. (the range value of Flourishes II is 0)

just modify line 154 to "ability_en = res.job_abilities[ability].en" work well at JP client but didn't try it at EN client :)

— Reply to this email directly, view it on GitHubhttps://github.com/SammehFFXI/FFXIAddons/issues/7#issuecomment-1709287307, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKJXEHWL6T6DA6OWEPMVFEDXZEHDZANCNFSM4DZMKPYQ. You are receiving this because you commented.Message ID: @.***>

Disclaimer: This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee, you should not disseminate, distribute or copy this email. Please notify the sender immediately by email if you have received this email by mistake and delete this email from your system. If you are not the intended recipient, you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.