search

Sammers21 / sArena_Updated2_by_sammers

sArena version that works in WoW 11.0+
MIT License
3 stars 3 forks source link

Absorb graphic changes #11

Closed devai42coding closed 3 months ago

devai42coding commented 3 months ago

Absorb graphic changes adding overlay on texture

Sammers21 commented 3 months ago

@devai42coding thank you for the Pull Request. Can you please change the base branch to master?

devai42coding commented 3 months ago

@Sammers21 Set to master now

Sammers21 commented 3 months ago

@devai42coding with that change absorbs are looking a way better. But the texture is looking more dark than it should be. How it looks: image image

How it should look(on the rogue): image

devai42coding commented 3 months ago

@Sammers21 This looks the same now compared to the picture above I would say: image

Also a side question. What addon do you make the graphics so much high resolution on partyframes, icons, sarena like the screenshots above? Looks clean.

devai42coding commented 3 months ago

Updated PR with the above changes

Sammers21 commented 3 months ago

@devai42coding ok i will test it. Thank you

Sammers21 commented 3 months ago

@devai42coding that looks better, but still i feel like its a bit dark or shady comparting to the absorbs on blizzard frames

image

Sammers21 commented 3 months ago

I will merge it and release a new version @devai42coding. Thank you for the contribution. But if you feel like you can make it look closer to the original absorbs on blizzard frames feel free to make another PR

devai42coding commented 3 months ago

@devai42coding that looks better, but still i feel like its a bit dark or shady comparting to the absorbs on blizzard frames

image

I suspect it is addon skin related. this is how it looks like for me: image image

So not sure why it shows darker on yours with newest commit.