Sammers21 / sArena_Updated2_by_sammers

sArena version that works in WoW 10.2+
MIT License
3 stars 2 forks source link

Bugs for certain users that use a specific layout #13

Closed Sammers21 closed 1 month ago

Sammers21 commented 1 month ago

Some of the users having issues like that: image

when /sarena is being type the issue appers: image

Here is some of the errors from bugrubber:

19x ...a_Updated2_by_sammers/Modules/DiminishingReturns.lua:88: attempt to index local 'layoutdb' (a nil value)
[string "@sArena_Updated2_by_sammers/Modules/DiminishingReturns.lua"]:88: in function `UpdateDRPositions'
[string "*sArena.xml:50_OnShow"]:1: in function <[string "*sArena.xml:50_OnShow"]:1>
[string "=[C]"]: ?
[string "=[C]"]: in function `SetCooldown'
[string "@sArena_Updated2_by_sammers/Modules/DiminishingReturns.lua"]:68: in function `FindDR'
[string "@sArena_Updated2_by_sammers/sArena.lua"]:137: in function <sArena_Updated2_by_sammers/sArena.lua:113>

Locals:
self = sArenaEnemyFrame2 {
 SpecIcon = Frame {
 }
 healAbsorbBarRightShadow = Texture {
 }
 PowerText = FontString {
 }
 Incapacitate = Frame {
 }
 healthbar = StatusBar {
 }
 TexturePool = <table> {
 }
 ClassIconMask = MaskTexture {
 }
 myHealPredictionBar = Texture {
 }
 overHealAbsorbGlow = Texture {
 }
 healAbsorbBar = Texture {
 }
 unit = "arena2"
 CastBar = StatusBar {
 }
 totalAbsorbBar = Texture {
 }
 currentClassIconTexture = "class"
 Trinket = Frame {
 }
 Name = FontString {
 }
 otherHealPredictionBar = Texture {
 }
 parent = sArena {
 }
 currentClassIconStartTime = 0
 healAbsorbBarLeftShadow = Texture {
 }
 Stun = Frame {
 }
 totalAbsorbBarOverlay = Texture {
 }
 overAbsorbGlow = Texture {
 }
 ClassIconCooldown = Cooldown {
 }
 specTexture = 135846
 Racial = Frame {
 }
 currentAuraDuration = 0
 Disorient = Frame {
 }
 race = "NightElf"
 PowerBar = StatusBar {
 }
 class = "MAGE"
 HealthBar = StatusBar {
 }
 Root = Frame {
 }
 currentAuraStartTime = 0
 DeathIcon = Texture {
 }
 Silence = Frame {
 }
 hideStatusText = false
 HealthText = FontString {
 }
 ClassIcon = Texture {
 }
}
layoutdb = nil
numActive = 0
frame = nil
prevFrame = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'layoutdb' (a nil value)"
drCategories = <table> {
 1 = "Stun"
 2 = "Incapacitate"
 3 = "Disorient"
 4 = "Silence"
 5 = "Root"
}
578x FontString:SetText(): Font not set
Lua Taint: sArena_Updated2_by_sammers
[string "=[C]"]: in function SetText'
[string "@sArena_Updated2_by_sammers/sArena.lua"]:959: in function SetStatusText'
[string "@sArena_Updated2_by_sammers/sArena.lua"]:516: in function SetMysteryPlayer'
[string "@sArena_Updated2_by_sammers/sArena.lua"]:466: in function UpdatePlayer'
[string "@sArena_Updated2_by_sammers/sArena.lua"]:340: in function <sArena_Updated2_by_sammers/sArena.lua:327>

Locals:
(temporary) = FontString {
}
(temporary) = ""
Sammers21 commented 1 month ago

@devai42coding can you take a look at that?

devai42coding commented 1 month ago

@Sammers21 Can you verify with the user that the user is running the latest sarena version? The background on the frames being invisible and the variable healAbsorbBarRightShadow and healAbsorbBarLeftShadow showing in the bugsack could indicate this is an earlier version than the newest.

Sammers21 commented 1 month ago

Yes @devai42coding i checked his version in curseforge it was the latest one on the curseforge: https://github.com/Sammers21/sArena_Updated2_by_sammers/releases/tag/2024.7.2-pre.559e830

And i think there is other ppl who has updated and have some issue.

Sammers21 commented 1 month ago

In curse forge it was showing as the version is the latest, i guess its not. That's weird. I aslo have noticed that test is looking a little weird: image image

devai42coding commented 1 month ago

@Sammers21 Yes switching layout will cause this and requires a /reload - Not sure what is causing it, so maybe to avoid it a reload should be forced somehow when switching layouts. Havent spent too much time on it because it’s a one time thing for most people. They select their layout and they are set.

Also not sure if you saw my previous question: Also a side question. What addon do you make the graphics so much high resolution on partyframes, icons, sarena like the screenshots above? Looks clean.

Sammers21 commented 1 month ago

Also a side question. What addon do you make the graphics so much high resolution on partyframes, icons, sarena like the screenshots above? Looks clean.

I don't use anything specific. The reason it looks like that is proly because i use a 4k screen.

devai42coding commented 1 month ago

@Sammers21 Ah alright, that makes sense. Then I just don’t understand why the absorb colors looks different for you than me (I posted some screenshots in the merged PR)

devai42coding commented 1 month ago

In curse forge it was showing as the version is the latest, i guess its not. That's weird. I aslo have noticed that test is looking a little weird: image image

To avoid confusion regarding the issue, I have added this: image

When switching layout in sArena, it will prompt the user and ask to reload.

PR: https://github.com/Sammers21/sArena_Updated2_by_sammers/pull/14

Sammers21 commented 1 month ago

@devai42coding, cool.

Look at this btw: https://www.twitch.tv/videos/2209579357?t=01h40m24s

sArena looks dark on his steram, the colors: image

Sammers21 commented 1 month ago

image everything is looking very dark

devai42coding commented 1 month ago

@devai42coding, cool.

Look at this btw: https://www.twitch.tv/videos/2209579357?t=01h40m24s

sArena looks dark on his steram, the colors: image

My guess is it’s an addon or some settings interferring since I have never seen that nor have I seen it on other streams I have watched recently.

Sammers21 commented 1 month ago

Not sure, but could be ye.

Sammers21 commented 1 month ago

@devai42coding can you look at this please:

image

Thats from Lontars strem: https://www.twitch.tv/videos/2210263573?t=02h18m43s

devai42coding commented 1 month ago

@devai42coding can you look at this please: image

Thats from Lontars strem: https://www.twitch.tv/videos/2210263573?t=02h18m43s

@Sammers21 I see the issue, try this: https://github.com/Sammers21/sArena_Updated2_by_sammers/pull/15

Sammers21 commented 1 month ago

@devai42coding thanks, that fixed that issue and the one with shadowing