Sarena updates to make it compatible with TWW 11.0

Sammers21 / sArena_Updated2_by_sammers

sArena version that works in WoW 10.2+

MIT License

3 stars 2 forks source link

Sarena updates to make it compatible with TWW 11.0 #4

Closed devai42coding closed 2 months ago

devai42coding commented 2 months ago

This PR makes sArena compatible with TWW 11.0 after API deprecations and other changes that were done between 10.2.7 and 11.0. Ace3 was also updated to 11.0.

Current known issues: Minor:

hpUnderlay and ppUnderlay is working for any of the layouts, however switching layout requires a reload to not mess up the textures.

Sammers21 commented 2 months ago

@devai42coding, thank you for the PR. I will test the changes today on Beta. If it works fine i will merge.

Also i have a question. How did you figure out that GetSpellTexture should be replaced with C_Spell.GetSpellTexture(spellID)? Is there any changelogs of what should be changed and how?

Sammers21 commented 2 months ago

@devai42coding i have tested it. It works. Thank you for the PR!

devai42coding commented 2 months ago

@Sammers21 - Great, glad to hear it and no problem, I am happy to support sArena is being kept alive.

Regarding the question with API changes. I haven't found any good changelogs, but I searched through the Deprecated API folders in here: https://github.com/Gethe/wow-ui-source/blob/beta/Interface/AddOns/Blizzard_Deprecated/11_0_0_SpellBookAPITransitionGuide.lua when something ingame was caught by Bugsack. These folders contains all deprecations and on which versions they will be removed. Hope it helps.

Sammers21 commented 2 months ago

@devai42coding cool