search

Sammers21 / sArena_Updated2_by_sammers

sArena version that works in WoW 11.0+
MIT License
3 stars 3 forks source link

Absorbs are not being shown properly #8

Closed Sammers21 closed 3 months ago

Sammers21 commented 3 months ago

They are not being shown at all atm.

devai42coding commented 3 months ago

@Sammers21 Do you have an example of what it should show? Just to get an idea of what is not working and how it should be displayed when working

Sammers21 commented 3 months ago

image @devai42coding, this is the example of the absorb texture

devai42coding commented 3 months ago

Hi @Sammers21

I have had a look at the API changes and it indeed look like they removed the used templates back then.

However, it looks like they have added the templates back on Beta.

These were the templates on 10.2.0 where it worked before the breaking changes in 10.2.5:

https://github.com/Gethe/wow-ui-source/blob/10.2.0/Interface/FrameXML/UnitFrame.xml

These are the templates on live:

https://github.com/Gethe/wow-ui-source/blob/live/Interface/AddOns/Blizzard_UnitFrame/UnitFrame.xml

These are the templates on beta:

https://github.com/Gethe/wow-ui-source/blob/beta/Interface/AddOns/Blizzard_UnitFrame/UnitFrame.xml

This shows the templates that were used with sArena back then are readded back.

I have reverted the changes you did back then to solve the XML issues below:

https://github.com/devai42coding/sArena_Updated2_by_sammers/commit/a57ae0f3dc0578e43b2ffa8edfaea7455bac8d4f

I have not been able to test this yet at all other than implementing the changes and logging in on beta to see there are no BugSack errors. I Think we should try to test this to see if it works again since the removed templates are back.

devai42coding commented 3 months ago

I just got to test it on Beta. Unfortunately it did not work - There are no lua errors, but it seems the functionality somewhere must have changed.

devai42coding commented 3 months ago

@Sammers21 - Created a PR for absorb implementation that have worked for me in the last 3 lobbies. Might still need some work, but it’s a start. PR also fixes other issues #10

Sammers21 commented 3 months ago

It looks like the whole structure is too densed into a small thing image

It should look more like: image

@devai42coding here is the vod where i play with the new version https://www.twitch.tv/videos/2205909170

devai42coding commented 3 months ago

@Sammers21 You mean the texture is different on sarena and party frames? Yes unfortunately implementing the texture (two textures) actually that is implemented on the party frames was causing issues, so I went with the shield-fill texture just to get the absorb implementation in a working state.

Sammers21 commented 3 months ago

@devai42coding is it possible to use the same texture as on party frames? Its been looking the same before it broke

devai42coding commented 3 months ago

@Sammers21 It is possible yes - Will take a bit to implement, but should be easier to test now since new patch is live. I will give it a look when possible.

Sammers21 commented 3 months ago

@devai42coding ait thank you. Would be nice

devai42coding commented 3 months ago

@Sammers21 Is this better? image

image

PR created in case it's what you wanted: #11