search

SammyK / LaravelFacebookSdk

Fully unit tested Facebook SDK v5 integration for Laravel & Lumen
MIT License
692 stars 200 forks source link

Improve ServiceProvider #182

Closed arubacao closed 7 years ago

arubacao commented 7 years ago
  1. Return boot method immediately if not running in console
  2. Defer Provider - https://laravel.com/docs/5.4/providers#deferred-providers
  3. Make config publishing optional instead of obligatory

Cheers, Chris

arubacao commented 7 years ago

BTW: Tests are all passing. It only fails on hhvm due to travis: HHVM is no longer supported on Ubuntu Precise. Please consider using Trusty with 'dist: trusty'.

SammyK commented 7 years ago

Thanks so much @arubacao! :)