SammyK / LaravelFacebookSdk

Fully unit tested Facebook SDK v5 integration for Laravel & Lumen
MIT License
693 stars 201 forks source link

Laravel 7 support #222

Open bbashel1 opened 4 years ago

bbashel1 commented 4 years ago

I added laravel 7 support in this fork if anyone wants to use. https://github.com/bbashel1/LaravelFacebookSdk

Fuhrmann commented 4 years ago

I do not see any changes to the code in your forked version of the package, what exactly did you changed?

Here, it`s in another branch: https://github.com/bbashel1/LaravelFacebookSdk/tree/laravel-7-support

MarcoTroost commented 4 years ago

Awesome, thank you for the fork. How do I point to this specific fork from my composer.json?

Thus far I have:

"repositories": [ { "type": "vcs", "url": "https://github.com/s1rc/LaravelFacebookSdk" } ], "require": { "sammyk/laravel-facebook-sdk": "dev-s1rc:30" },

But that doesn't work. Any ideas?

smartssa commented 4 years ago

@MarcoTroost you need to add the 'name' to override the origin in your repository block.

  {
    "type": "vcs",
    "name":"sammyk/laravel-facebook-sdk",
    "url": "https://github.com/s1rc/LaravelFacebookSdk"
  }],
  "require": {
    "sammyk/laravel-facebook-sdk": "dev-s1rc:30"
  }

Otherwise, it will look at the origin for sammyk's package.

theamanjs commented 3 years ago

@smartssa if I'll use this will there be any change in code or will anything break after this?

smartssa commented 3 years ago

I cannot confirm changes to code in this branch (it's not mine) - you can check the history. I forked my own from sammyk and only changed the dependency. No other code changes were needed for my own personal usage.

geoff-maddock commented 3 years ago

Anyone looking to update this to Laravel 8? I use it in my package and was looking at updating.

devinyasas commented 3 years ago

I updated my project to Laravel 8. And when upgrading, I didn't get any errors. It's strange and I It's working. Is this normal? Can someone explain me?