Facebook PHP SDK Laundry List

[SammyK]

Hey @stevenmaguire, @nickescobedo! I've been getting a laundry list of things to contribute to the Facebook PHP SDK. We can get to together sometime and go over them in person if you like or we can just talk about them at the open source workshop in a few weeks. But wanted to show you guys the list so far:

Beginner

• [x] Make PSR-2 compliant (pending @gfosco's approval) blessing granted!
• [ ] Propose consistent docblocks standard & fix (would require discussion in main repo)
• [ ] Add more GraphNode subtypes
• [ ] Add more getters and auto-casters to the existing GraphNode subtypes
• [x] Remove any mention of authors from docblocks a let git keep track of authorship
• [ ] Update error message in Facebook for "The pseudo_random_string_generator must be an instance "... to include the string options.
• [ ] Add tests for getReRequestUrl() and getReAuthenticationUrl() in FacebookRedirectLoginHelper
• [x] Remove isLiked() from FacebookPageTabHelper
• [x] Remove the $state dingle-berries from FacebookSignedRequestFromInputHelper
• [x] Remove FacebookSignedRequestFromInputHelper::getRawSignedRequestFromGet() since that's never been a thing. :)
• [x] Remove all references to \\. (Except in composer.json)
• [x] Remove any \ prefixes in use statements
• [ ] Fix docblocks in tests/ of mocks to point to \Mockery\MockInterface
• [ ] In FacebookTest, unset the env fallback vars to not throw false positive.

  Intermediate

• [ ] Find instances where naming conventions do not conform to a ubiquitous language within Facebook's domain and propose a change. (usually a BC though)
• [ ] Add /{user-id}/permissions endpoint helper/service to make it easier to check what permissions were granted?
• [ ] Add auth_nonce support
• [ ] Make default Graph version unprefixed per Facebook#332

  Advanced

• [ ] Review of handling of auto-casting Graph responses to GraphNodes
• [ ] Review of generation of page URL's based on pagination cursors
• [ ] Add some sort of event system
• [ ] Add logger for debugging in dev mode (could tie into event system)
  • [ ] In logger, notify dev when facebook-api-version header returns unexpected value (when Graph is force-upgraded for example)
• [ ] Add plugin functionality (could tie into event system)

[stevenmaguire]

Great list @SammyK!

Is dingle-berries a technical term? :)

[SammyK]

I think it is in fact. :)

[nickescobedo]

This is awesome and very helpful, thank you! I wouldn't mind getting together sometime to talk about some of these.

[SammyK]

No problem! So I actually just realized that I'll be out of town from this Friday until the day before the open source workshop. Lol. So I guess I'll see you guys then. :)

[stevenmaguire]

I am taking care of:

• Remove any \ prefixes in use statements
• Remove all references to . (Except in composer.json)
• Remove any mention of authors from docblocks a let git keep track of authorship

The PR for it is https://github.com/facebook/facebook-php-sdk-v4/pull/334

[stevenmaguire]

I am taking care of:

• Remove isLiked() from FacebookPageTabHelper

The PR for it is https://github.com/facebook/facebook-php-sdk-v4/pull/335

[stevenmaguire]

I am taking care of:

• Remove FacebookSignedRequestFromInputHelper::getRawSignedRequestFromGet() since that's never been a thing. :)
• Remove the $state dingle-berries from FacebookSignedRequestFromInputHelper

The PR for it is https://github.com/facebook/facebook-php-sdk-v4/pull/336

[SammyK]

Nice! :)

[stevenmaguire]

I am beginning the process of addressing:

• Add more GraphNode subtypes

The PR for the first one (achievement) is https://github.com/facebook/facebook-php-sdk-v4/pull/337

[SammyK]

We got the official blessing to make the PHP SDK PSR-2 compliant! W00t! :)

[stevenmaguire]

@SammyK I saw! That's awesome.

[SammyK]

We should talk stagey at the workshop of how to tackle that one and get as many hands in that one as possible. :)