search

SammySemicolon / Malum-Mod

A minecraft mod about dark magic.
GNU Lesser General Public License v3.0
90 stars 36 forks source link

NullPointerException crash from Totem Base ticking #226

Closed CelestialAbyss closed 11 months ago

CelestialAbyss commented 11 months ago

MC version: 1.19.2 Forge: 43.3.2 Malum version: 1.5.0.3 Lodestone version: 1.4.2

I was not on while players were doing Malum related things, but it might be conflicting with chunk claims from Open Parties & Claims but I'm not too sure.

Edit: It is due to moving the totem base with Carry On, see here: Discord CDN

Edit 2: It also seems that a server restarting while a totem is in progress also causes the same issue to occur.

Gist is attached here: https://gist.github.com/CelestialAbyss/d058d3774cb6da590437907103da9c75

CelestialAbyss commented 11 months ago

Another related crash: https://gist.github.com/CelestialAbyss/98245181190896f4a88ad2bb3e9a6fbc

SammySemicolon commented 11 months ago

I'm sorry for not fixing it earlier, life has been a mess and I've had no motivation. Please try this jar and let me know if it fixes ur issue https://legacy.curseforge.com/minecraft/mc-mods/malum/files/4952075

CelestialAbyss commented 11 months ago

I was about to remove your mod in the next modpack update that I was going to publish due to the crashes occurring more and more often with the same cause, but good to see the bug actually patched after being ignored on the Discord after asking about it...

I'll release an update for my players hopefully later today or two days from now and see if my personal server no longer crashes with this.

More importantly, take care of yourself first and foremost.

CelestialAbyss commented 11 months ago

Okay, it seems like the error has yet to re-occur so it seems fixed... though there's a new issue that only happens with Malum's signs.

SammySemicolon commented 11 months ago

The malum signs have been a problem for a while, they straight up do not have a proper renderer.