search

SammySemicolon / Omnis

3 stars 1 forks source link

Omnis gives Savage and Ravage's Executioner a vindicator axe #3

Closed NJL5390 closed 3 years ago

NJL5390 commented 3 years ago

Mod Versions: Abnormals Core: 3.1.1 Savage and Ravage: 3.1.0 Omnis version: 1.1.1 Curios version: 4.0.5.1 Forge Version: 36.1.16

Hello!

First of all, I just wanted to say that I love this mod and the concepts behind it and I look forward to what you have planned for the future of this mod!

Secondly, I noticed an issue when testing this alongside Savage and Ravage (Which adds several new illager types) specifically in relation to an illager called the Executioner. I have noticed that when omnis is installed, the executioner's weapon is replaced by this mod's vindicator axe: 2021-05-05_20 15 44 2021-05-05_20 30 51 This shouldn't be the case since Savage and Ravage adds a unique weapon specifically for this mob called the Cleaver of beheading which can only be obtained from this mob. This issue therefore makes this weapon unobtainable.

My latest log can be found here: https://gist.github.com/NJL5390/a7fb34a8bc0f9d06d77401ba2f91a697

Thanks for the work you do on this mod! It has a bright future!

SammySemicolon commented 3 years ago

This actually brought up 2 issues, I may have forgotten to uncomment a line of code that makes the weapons only sometimes be given to their respective entities. Thank you for posting the issue! <3

NJL5390 commented 3 years ago

This actually brought up 2 issues, I may have forgotten to uncomment a line of code that makes the weapons only sometimes be given to their respective entities.

I think you're right because some other things I've noticed with the recent update was that vindicators and vexes now always have their respective Omnis weapons and they always drop them when killed. (I meant to create separate issues for those but I forgot/ was busy Sorry)