search

Sammyjo20 / lasso

🐎 Lasso is a Laravel package created to make your deployments blazing fast.
MIT License
341 stars 16 forks source link

Max_bundles not working properly #18

Closed likeadeckofcards closed 3 years ago

likeadeckofcards commented 4 years ago

I recently installed this package. It looks like the max_bundles setting is not working correctly. My setting is set to 5 bundles.

Screen Shot 2020-09-10 at 6 11 41 PM

likeadeckofcards commented 4 years ago

Actually this might be an issue where the process did not finish but uploaded the bundles but did not update the history.json file

Sammyjo20 commented 4 years ago

Hey @likeadeckofcards, yeah I noticed this too yesterday - the bundles are getting deleted but not being removed from the history.json file. It’s on my list for things to fix but thank you for confirming the bug, I’ll get it sorted soon! ✌️

likeadeckofcards commented 3 years ago

I am closing this because the extra bundles that I was seeing were due to failed deployments, where the code threw an exception.

Sammyjo20 commented 3 years ago

Great - I did look into this a little bit but couldn't find a bug. Glad it's working!