search

Sammyjo20 / lasso

🐎 Lasso is a Laravel package created to make your deployments blazing fast.
MIT License
341 stars 16 forks source link

Add tests for ConfigValidator #41

Closed husonghua closed 3 years ago

husonghua commented 3 years ago

Hey Sam, I have been using Lasso for a while now and think I should contribute somehow. I am adding ConfigValidator tests and hope that will check one box on your Issue #38. I am relatively new to open source and let me know if something is not up to the standard. Thanks!

Sammyjo20 commented 3 years ago

Hey @husonghua, thank you so much! 🙏 I've taken a look at your PR and it looks good so far, I noticed a couple of things that could be changed.

Please could you remove test "it_throws_exception_when_storage_push_to_git_is_set" because this is legacy code, and Lasso no longer supports the "push to git" feature.

One other thing - please could you rename the last test from "final_test" to "it_throws_exception_when_public_path_is_inaccessible"

Thanks!

Sammyjo20 commented 3 years ago

Ah, just remembered the push_to_git message and it stops people from using that key - please keep this in.

husonghua commented 3 years ago

Just fixed the test function name. I overlooked it when I rushed for the push yesterday.

I will try to help out with additional test coverage when I have some free time. Thanks!

Sammyjo20 commented 3 years ago

Thank you for helping, husonghua