search

Sammyjo20 / lasso

🐎 Lasso is a Laravel package created to make your deployments blazing fast.
MIT License
341 stars 16 forks source link

Breaks application after installation with cached config #43

Closed srichter closed 3 years ago

srichter commented 3 years ago

If your application's config is cached, installing Lasso will break the application (making the config cache unable to be cleared as well).

Since Lasso always registers into the container (#23) it will break when the Filesystem helper attempts to instantiate, due to null being passed to setCloudDisk() as that's what is returned from the config() helper due to no Lasso configuration being cached (it would break on setPublicPath() as well).

A temporary fix until #23 is resolved would be to just provide defaults for the config values here, like is done already for lasso.storage.environment.

Sammyjo20 commented 3 years ago

Hey @srichter

Thank you for your comment - I am aware of this issue. A workaround is to delete the 'config.php' cache file in '/bootstrap/cache'

I will definitely get this sorted though so thank you for raising it here!

Sammyjo20 commented 3 years ago

I have fixed this in #45 ! Thanks for reporting @srichter