search

Sammyjo20 / lasso

🐎 Lasso is a Laravel package created to make your deployments blazing fast.
MIT License
341 stars 16 forks source link

Replaced ->putStream() with ->put() #59

Closed alexjustesen closed 2 years ago

alexjustesen commented 2 years ago

This PR proposes a change to Helpers/Cloud.php and changes ->putStream() to ->put(). Looks like this method is no longer available in illuminate/filesystem.

jrmajor commented 2 years ago

@Sammyjo20 Could you have a look at this?

Thanks to Laravel magic I'm not sure where this method was removed from. It could have been a method on Illuminate\Filesystem\FilesystemAdapter, a method on League\Flysystem\Filesystem, or a macro.

Whatever it was, it's clearly not there now: https://github.com/jrmajor/bajki-muza/runs/5206287335.

Sammyjo20 commented 2 years ago

@jrmajor Yep I'll take a look as soon as possible

StanBarrows commented 2 years ago

Hey @Sammyjo20

Can I support you with anything to get this merged?

Cheers Sebastian

Sammyjo20 commented 2 years ago

A PR would be welcome! 🤗 Thank you.

nckrtl commented 2 years ago

putStream is being used in multiple places. So a search and replace would come in handy I think. Would you like to apply that for this PR @alexjustesen. If not, I'm more than happy to provide an additional PR myself.

alexjustesen commented 2 years ago

@nckrtl looks like the only other place ->putStream() is referenced is in src/Helpers/Filesystem.php as a method which is referenced in src/Tasks/Pull/PullJob.php. Likely done for coverage on the local file system vs. the cloud but I'm on coffee #1 so I'll let @Sammyjo20 correct me on that one.

nckrtl commented 2 years ago

@Sammyjo20 you are probably very busy, but is there anything we can do to help get this merged? Thanks in advance.

Sammyjo20 commented 2 years ago

@nckrtl I will try and sort this tonight for you all!

Sammyjo20 commented 2 years ago

Hey all! Right I've got a PR #61 here which should resolve the issue while still allowing Lasso to have large zip sizes without running out of memory. I've tested it with a local driver, and it seems to work well. Please let me know if it sorts it!

alexjustesen commented 2 years ago

Sweet, thank you! I'll close out my PR as it's no longer needed.