Thanks! - Githubissues

dattran2346 commented 7 years ago

Thank you for your submission

Congratulation, you have completed all the requirements in a very short time. However, this is just a very naive implementation of the app, I believe that with your prior experience with Android, you can do much better.

Suggesstions

Since we have had some really good submissions, you will have better chance if you can put some time to do these suggestion:

Instead of using ListView and ArrayAdapter, you can use RecyclerView and a custom RecyclerAdapter to customize the look of each todo item
Instead of using putExtra("ToDoItem"), you can extract the ToDoItem string into public final String ToDoItem = "ToDoItem" constant, I have seen people make bugs because they mistype the word
Try yourself with ButterKnife, this is a very easy to use library to reduce findViewById() boilerplate code, they also support onClick() very nicely Ps: About github, I found that this Udacity course really help me, these video are short and quite easy to understand, you can learn in just 1 week

dattran2346 commented 7 years ago

@Samn2NPA It would be very nice of you to do some of my suggestion. I think you CAN do better with all of your Android's experience!! 😄

Samn2NPA commented 7 years ago

@dattran2346 I've tried to use ButterKnife as you suggested, but it's not work properly, it can not sync when I add library of ButterKnife.

dattran2346 commented 7 years ago

Can you show me the gradle error please. And what happen to your repository, I cant see any of you project folder??

Samn2NPA commented 7 years ago

https://github.com/Samn2NPA/ToDoApp/tree/PreWork

Here is my code. It such a mess at the first time upload code on Github, sorrry about that. I'm still working with my app so I have not submitted it on Github yet.

dattran2346 commented 7 years ago

I think you have missing something on build.gradle file, may be this link can help you with ButterKnife http://guides.codepath.com/android/Reducing-View-Boilerplate-with-Butterknife

dattran2346 commented 7 years ago

Do you have any other problems? Feel free to ask!!

Samn2NPA commented 7 years ago

sure, thank you very much. I started to do it all over again. :)) hope you won't be disappointed :D

dattran2346 commented 7 years ago

Hope to see you change soon 👍

Samn2NPA / ToDoApp

Thanks! #2

Thank you for your submission

Suggesstions