Samourai-Wallet / whirlpool-client-cli

Command line Whirlpool client
Other
16 stars 13 forks source link

UTXO selection for freeriding based on confirmations #17

Closed Crazyk031 closed 4 years ago

Crazyk031 commented 4 years ago

As it stands now it seems the same "coins/UTXOs" just keep getting cycled over & over, so if you have a large set of UTXOs in Whirlpool many mix once and thats it, then a small minority keep getting freerides. My suggestion is UTXOs get chosen for freerides based on which has the most confirmations. Then your whole UTXO stack would constantly cycle through evenly.

zeroleak commented 4 years ago

great suggestion, thx! Adding this to next release

LaurentMT commented 4 years ago

A random selection from all candidate UTXOs seems better, privacy-wise. A deterministic selection based on number of past freerides may be used to weaken the anonymity set provided by the mixes.

SamouraiDev commented 4 years ago

Previous discussions on this have always resulted in non-deterministic solutions (random selection).

zeroleak commented 4 years ago

Fixed a bug causing the issue. Utxos will be randomly cycled more uniformly now.

Crazyk031 commented 4 years ago

Awesome, glad to see this was a bug that could be squashed.

zeroleak commented 4 years ago

fixed in 0.10.3