Samourai-Wallet / whirlpool-client-cli

Command line Whirlpool client
Other
16 stars 13 forks source link

Reason for utilising clearnet address instead of OnionV3 address #7

Closed Technifocal closed 5 years ago

Technifocal commented 5 years ago

As per @SamouraiDev's suggestion on Telegram, I am posting this question here:

In the function computeServerUrl() you always return the clearnet server URL defined here.

As the code to detect Tor and return the Tor hidden service is specifically commented out, I'm wondering what the reason for not using the Tor V3 address is? Especially as the Tor hidden service is up and running:

$ torify curl 'udkmfc5j6zvv3ysavbrwzhwji4hpyfe3apqa6yst7c7l32mygf65g4ad.onion/rest/pools'                                                                                                                     
{"pools":[...]}

Thanks.

zeroleak commented 5 years ago

You are right, this is planed for next releases. We need to make sure this will work correctly on Tor V3 hiddenservices (as V2 is flawed). We got 0.7.0 released early to make sure tor client is stable enough on each platform, before going further.

zeroleak commented 5 years ago

implemented in next release