Samoxive / SafetyJim

A moderation bot for discord.
https://safetyjim.xyz
MIT License
37 stars 13 forks source link

Silent Mode breaks conversations #28

Closed lethargilistic closed 6 years ago

lethargilistic commented 7 years ago

Having used the new silent mode for a while, I like that we're hiding the messages from users to avoid public shame. However, I feel like it's breaking conversations. This doesn't matter for warnings, because those have no consequences.However, a kick or a ban means that person is no longer there. The only way people know that is if people congratulate the bot after the action takes place.

I propose having Jim send a message simply saying "Username#1234 was kicked/banned" after deleting the message with the reason. That way, silent mode preserves its "no shame" purpose, but also informs people of the change.

Samoxive commented 7 years ago

Sounds like a good suggestion, I understand that this would still hide the reason. I think this would be fit for ban, kick, softban, mute commands? Maybe warnings aren't meant to be public at all? This is totally doable with the next minor release.

lethargilistic commented 6 years ago

The active voice is probably better for the message. Perhaps:

Samoxive commented 6 years ago

Good idea, however Jim currently has no functionality voice-chat wise. And for the announcement to work, every online guild member (at least some significant portion of the community) would need to be in a channel Jim sits in. I feel like announcing via text message would be the most convenient solution.

lethargilistic commented 6 years ago

"Active voice" is an English grammar term. It makes sentences easier to understand than the "passive voice." At this scale, it doesn't matter that much, but "It was done" isn't as punchy as "I've done it."

Samoxive commented 6 years ago

Right, sorry. We should definitely use that structure for the announcements. @ozankaraali can look into this.

Samoxive commented 6 years ago

In both typescript version and java, enabling SilentCommands setting now removes every command message, in rewrite, moderative commands also announce that an action was taken against the target user, this issue can now be closed.