search

Samraksh / eMote

eMote OS -- Multiple Ports (using .NET MF v4.3)
0 stars 0 forks source link

eMote: Move platform independent code out of "drivers" #171

Closed Nathan-Stohs closed 9 years ago

Nathan-Stohs commented 10 years ago

Samraksh_eMote should be the same for all platforms and could be removed from the target specific platforms and placed in a directory that applies to all platforms.

See comments in commit d73dd53afee85669d9b22d3242b590da6cdb7e62

ChrisAtSamraksh commented 9 years ago

The Samraksh_eMote directory could easily be moved from DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\Targets\Native\STM32F10x\DeviceCode\drivers\Samraksh_eMote to DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\pal\Samraksh

Does anyone have a better place?

Nathan-Stohs commented 9 years ago

The Samraksh_eMote directory could easily be moved from DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\Targets\Native\STM32F10x\DeviceCode\drivers\Samraksh_eMote to DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\pal\Samraksh

Does anyone have a better place?

That location seems very reasonable. But make sure you agree with my claim that everything in question here is platform independent PAL code. For example, it occurs to me that we probably don't want to move Samraksh_eMote_DotNow, because it is specific to the .NOW.

Some of these interops might need to be further chopped up into PAL/HAL pairs, but doesn't have to be now.

AnanthAtSamraksh commented 9 years ago

DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\pal\Samraksh

That is the right place for Samraksh_eMote (Samraksh_eMote_RealTime is already in that location). Samraksh_eMote_DSP has some platform dependent code (only in one function), else that also could be moved.

ChrisAtSamraksh commented 9 years ago

Moved in ba8b76b201a1b8f39d9b83775922de9e8b2db4a6