search

Samraksh / eMote

eMote OS -- Multiple Ports (using .NET MF v4.3)
0 stars 0 forks source link

SAM_VERSION_REVISION redefined build warning #352

Closed Nathan-Stohs closed 9 years ago

Nathan-Stohs commented 9 years ago

builds as of 3b396b3d775b2676e6a40a3896815f5edca6dfed (and earlier) produce numerous instances of:

In file included from e:\dotnet-mf\microframeworkpk_v4_3\devicecode\initialization\masterconfig.h:12:0,
                 from E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include/tinyhal.h:1523,
                 from E:\DotNet-MF\MicroFrameworkPK_v4_3\Solutions\EmoteDotNow\TinyCLR\tinyclr.cpp:6:
E:\DotNet-MF\MicroFrameworkPK_v4_3\Solutions\EmoteDotNow/platform_selector.h:19:0: warning: "SAM_VERSION_REVISION" redefined
 #define SAM_VERSION_REVISION 15
 ^
<command-line>:0:0: note: this is the location of the previous definition

or another example

   pto\inc -IE:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include -IE:\DotNet-MF\MicroFrameworkPK_v4_3\BuildOutput\THUMB2\GCC4.9\le\ANY_MEDIA\release\lib    -o E:\DotNet-MF\MicroFrameworkPK_v4_3\BuildOutput\THUMB
   2\GCC4.9\le\FLASH\release\EmoteDotNow\obj\DeviceCode\pal\Time\Time_functions.obj -c E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\Pal\Time\Time_functions.cpp
   In file included from e:\dotnet-mf\microframeworkpk_v4_3\devicecode\initialization\masterconfig.h:12:0,
                    from E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include/tinyhal.h:1523,
                    from E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\Pal\Time\Time_functions.cpp:5:
   E:\DotNet-MF\MicroFrameworkPK_v4_3\Solutions\EmoteDotNow/platform_selector.h:19:0: warning: "SAM_VERSION_REVISION" redefined
    #define SAM_VERSION_REVISION 15
    ^
   <command-line>:0:0: note: this is the location of the previous definition
 ArmBuildLib:
   "C:\GCC493\bin\arm-none-eabi-ar.exe"  -rcs E:\DotNet-MF\MicroFrameworkPK_v4_3\BuildOutput\THUMB2\GCC4.9\le\FLASH\release\EmoteDotNow\lib\Time_pal.lib Time_driver.obj Time_functions.obj
AnanthAtSamraksh commented 9 years ago

Are you using the TestSystem? I got this last week while using the TestSystem and informed Chris about it. He checked-in a fix for it - https://github.com/Samraksh/TestSystem/commit/6e992fb643e5f18782e890189b5122737fdda6a8

Nathan-Stohs commented 9 years ago

Are you using the TestSystem? I got this last week while using the TestSystem and informed Chris about it. He checked-in a fix for it - Samraksh/TestSystem@6e992fb

This is in current (EDIT: MF) master for TinyCLR builds. I think its a different although related issue than what you linked.

ChrisAtSamraksh commented 9 years ago

Are you defining SAM_VERSION_REVISION in your msbuild command line?

Nathan-Stohs commented 9 years ago

Are you defining SAM_VERSION_REVISION in your msbuild command line?

No. Should I be? My command line is always:

msbuild /maxcpucount /p:memory=FLASH,flavor=release /t:cleanbuild TinyCLR.proj

Do you not have this in your own build output? I am very confused if you don't.

ChrisAtSamraksh commented 9 years ago

No, you shouldn't be. A previous version of the TestSystem had SAM_VERSION_REVISION defined in the msbuild command line but we removed it. What you have is what the TestSystem uses.

Nathan-Stohs commented 9 years ago

No, you shouldn't be. A previous version of the TestSystem had SAM_VERSION_REVISION defined in the msbuild command line but we removed it. What you have is what the TestSystem uses.

So then what's the resolution here?

ChrisAtSamraksh commented 9 years ago

We need to remove the references from Microsoft.Spot.system.gcc.targets. I could see cases where we have to build a specific version of eMote for a specific platform, so we should keep the version number in the platform area.