search

Samraksh / eMote

eMote OS -- Multiple Ports (using .NET MF v4.3)
0 stars 0 forks source link

OMAC: warning: comparison between 'enum OMacInput_t' and 'enum OMacState_t' #433

Closed Nathan-Stohs closed 7 years ago

Nathan-Stohs commented 7 years ago

Lately builds have been emitting this warning in 7 or so places, for example:

In file included from E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include/Samraksh/MAC/OMAC/OMAC.h:40:0,
                 from E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\PAL\COM\Wireless\MAC\OMAC\OMAC.cpp:14:
E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include/Samraksh/MAC/OMAC/Scheduler.h: In member function 'bool State::RequestState(OMacInput_t)':
E:\DotNet-MF\MicroFrameworkPK_v4_3\DeviceCode\include/Samraksh/MAC/OMAC/Scheduler.h:44:53: warning: comparison between 'enum OMacInput_t' and 'enum OMacState_t' [-Wenum-compare]
   else if(CurrentState == S_STARTING && reqState == S_STARTING) {

This is probably harmless but would like somebody familiar with OMAC code to make sure everything is OK and tidy up.

EDIT: Added full example

AnanthAtSamraksh commented 7 years ago

Assigning Bora and removing myself as Bora has already fixed this with commit 1a05e20