search

SamsDRGMods / SimpleQOL

1 stars 0 forks source link

mission list doesn't support non-latin characters #8

Closed TyleRxYan closed 2 years ago

TyleRxYan commented 2 years ago

Describe the bug as title

To Reproduce change the game language to Chinese (and Korean I guess? not test yet)

Expected behavior properly display. It should be like upper-right in the screenshot

Screenshots 20220428055820_1.

Additional context I barely use it, so take your time. and I think the function should integrate in the map, or become a replacement of the Rig HUD with hazard bonus display, and it will be even better if the list is also clickable.

samamstar commented 2 years ago

Noted. I think this should be an easy fix, I just need to enable a fallback font with support for those characters... I think? I don't play with fonts much :P

samamstar commented 2 years ago

Fixed by DRGLib 4.4.0

TyleRxYan commented 2 years ago

image well...it is fixed ...... particatilly... I‘ve checked the drglib's changelog, the fallback font seems can not fully cover the simplified-chinese and traditional-chinese characteres, and it shouldn't because of size, so I still recommand to assign specific font depend on the UI language, the font come with vanilla game should be the best

samamstar commented 2 years ago

Well shoot; I went through all the effort of adding noto sans ch and forgot to add it as a sub-font family. Will fix soon; likely this weekend.

samamstar commented 2 years ago

I have no idea how fonts work. As far as I can tell, the font in DRGLib is missing specific glyphs in the CJK unified ideographs space; but fixing it is just not something I really have suitable knowledge to fix.

Believe me, it's not for lack of trying, but I've been banging my head against the wall for the last 5 days and have made little to no progress. If you absolutely need this fixed, DRGLib is open source and I'm always happy to accept contributions :)

samamstar commented 2 years ago

I'll see about using the ingame fonts; but that has it's own issues that I'll need to figure out.

And I am just so burnt out on this right now

samamstar commented 2 years ago

Ok I gave it one more try and I think I got it; finally.

TyleRxYan commented 2 years ago

thanks for your hard work, I appreciate that. Rock'n Stone, Brother!