search

SamsTheNerd / HexGloop

A very gloopy hex casting addon
GNU Lesser General Public License v3.0
4 stars 8 forks source link

Recipes use tag `c:yada_yada` instead of `forge:yada_yada` on forge #36

Open aaronhowser1 opened 10 months ago

aaronhowser1 commented 10 months ago

image

SamsTheNerd commented 10 months ago

hm, looks like the recipe loads/works fine and just alternates between the gold nugget and the empty tag showing, is that the same behavior for you?

currently I don't have my recipes split across platforms. I've been wanting to look into proper data gen in a future update, which would probably make this easier to fix.

aaronhowser1 commented 10 months ago

Yes, but that tag doesn't exist in forge. In forge, it's like forge:nuggets/gold or something like that, which is what I meant the problem to be

SamsTheNerd commented 10 months ago

oh, yeah, it should have both? https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/resources/data/hexgloop/recipes/casters_coin.json

The c:tag style is fabric's. idk why patchi only seems to show empty tags, or really why it shows them at all.

I'll run through the recipes again real quick before tonight's next release and make sure everything has a proper forge tag though.

aaronhowser1 commented 10 months ago

It shows both vanilla gold ingots as well as the c one, my point was that it probably shouldn't use the c one as that doesn't exist in forge

SamsTheNerd commented 10 months ago

yeah probably not lol. I'd have to keep two separate json files for each recipe with a tag though, which would be a lot easier with datagen, so probably something i'll get around to whenever i switch over to that.