SamsTheNerd / ducky-periphs

A peripheral addon mod for ComputerCraft Restitched
9 stars 3 forks source link

Recent CC update breaks PeriphsProviders #38

Open beegsinjnacon opened 5 months ago

beegsinjnacon commented 5 months ago

They changed Peripherals' getPeripheral() methods to use ServerLevel instead of Level, and I guess that is bad because now the calls to getBlockEntity() are returning null. It is not crashing or anything, but it prints a bunch of scary red text to the server log every time a computer is placed or loaded.

I am not too experienced with using peripherals yet, but I tried using a couple and the computer is aware of them, but can't seem to interact/call methods, as one might expect.

offending commit(i think)

Error:

Peripheral provider com.samsthenerd.duckyperiphs.forge.DuckyPeriphsProviderForge@6e1d1327 errored.
java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.block.entity.BlockEntity.m_58904_()" because "be" is null
    at TRANSFORMER/duckyperiphs@1.20.1-1.3.1/com.samsthenerd.duckyperiphs.hexcasting.lonelyPeripherals.DuckyCastingLonelyPeripheralProvider.getPeripheral(DuckyCastingLonelyPeripheralProvider.java:31)
    at TRANSFORMER/duckyperiphs@1.20.1-1.3.1/com.samsthenerd.duckyperiphs.peripherals.DuckyPeriphsProviderCommon.getPeripheral(DuckyPeriphsProviderCommon.java:29)
    at TRANSFORMER/duckyperiphs@1.20.1-1.3.1/com.samsthenerd.duckyperiphs.peripherals.DuckyPeriphsProviderCommon.getPeripheral(DuckyPeriphsProviderCommon.java:20)
    at TRANSFORMER/duckyperiphs@1.20.1-1.3.1/com.samsthenerd.duckyperiphs.forge.DuckyPeriphsProviderForge.getPeripheral(DuckyPeriphsProviderForge.java:17)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.impl.Peripherals.getPeripheral(Peripherals.java:87)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.platform.PlatformHelperImpl$PeripheralAccess.get(PlatformHelperImpl.java:452)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.platform.PlatformHelperImpl$PeripheralAccess.get(PlatformHelperImpl.java:444)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.platform.PlatformHelperImpl$ComponentAccessImpl.get(PlatformHelperImpl.java:435)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.computer.blocks.AbstractComputerBlockEntity.refreshPeripheral(AbstractComputerBlockEntity.java:220)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.computer.blocks.AbstractComputerBlockEntity.serverTick(AbstractComputerBlockEntity.java:128)
    at TRANSFORMER/computercraft@1.109.5/dan200.computercraft.shared.computer.blocks.AbstractComputerBlock.lambda$new$0(AbstractComputerBlock.java:45)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.mixinextras$bridge$m_155252_$11(LevelChunk.java)
    at TRANSFORMER/neruina@1.3.0/com.bawnorton.neruina.handler.NeruinaTickHandler.safelyTickBlockEntity$notTheCauseOfTickLag(NeruinaTickHandler.java:96)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.wrapOperation$clc000$catchTickingBlockEntity(LevelChunk.java:1313)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.m_142224_(LevelChunk.java:689)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.level.chunk.LevelChunk$RebindableTickingBlockEntityWrapper.m_142224_(LevelChunk.java:782)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.level.Level.m_46463_(Level.java:468)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:351)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:893)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:814)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:89)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:661)
    at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251)
    at java.base/java.lang.Thread.run(Thread.java:833)