SamsTheNerd / ducky-periphs

A peripheral addon mod for ComputerCraft Restitched
9 stars 3 forks source link

mineable pickaxe tags list replacing instead of appending #9

Closed LunaFolf closed 1 year ago

LunaFolf commented 1 year ago

In version 7.0.0 of my modpack, ducky periphs version 1.1.4 replaces the pickaxe mineables instead of appending to it - resulting in only ducky blocks being mineable with a pickaxe.

Removing the mod fixes the issue, (which is what hotfix 7.0.1 will be doing) and no other mod has this sort of behaviour.

My current theory is mod incompatability, but my pack has 182 mods so it's going to take some time for me to figure out what exactly (if I even can)... If I happen to get more information I'll append it onto this ticket.

SamsTheNerd commented 1 year ago

huh weird. Maybe try using REI or something to check if anything else is also in the tag ? (You can press r on any pickaxe mineable block, go over to tags and then expand to see everything) Maybe also check some of the other mineable tags maybe?

I don't think there's anything non standard about the pickaxe.json tag file and I can't reproduce the issue so there's not much I can do. Let me know if you find anything else though.

Also if it helps, I haven't had any issues with using this in all of fabric 6, idk if that could help narrow down the problem.

OvercastWarmth commented 1 year ago

Any chance that you could provide a startup log? It might show an error somewhere about it.

LunaFolf commented 1 year ago

Sorry been working and haven't had time to check in on this - I'll try get some more info later today.

MAGGen-hub commented 1 year ago

Same problem... Can't mine anything...

OvercastWarmth commented 1 year ago

Same problem... Can't mine anything...

Are you using the pack above or a different one? Can you send a log file?

LunaFolf commented 1 year ago

Any chance that you could provide a startup log? It might show an error somewhere about it.

ok sorry for taking so long to give this @Ringlings, ADHD sucks ass.

I read through the startup log and found the following which I think is our culprit for this issue:

[15:59:30] [Worker-Main-5/ERROR]: Couldn't load tag minecraft:mineable/pickaxe as it is missing following references: ducky-periphs:focal_port_block (from Ducky Peripherals)

Here is the whole latest.log file incase it's useful for additional info: https://gist.github.com/WhiskeeDev/cf54f4c626540b66397b47964f555fff

SamsTheNerd commented 1 year ago

oh i see, focal port only gets registered when hex casting is installed.

I'll look into the best way to fix that in the next release but if you want a quick fix you can install hex casting (with the bonus that you get another cool mod to play with lol)

LunaFolf commented 1 year ago

Yep I just realised that as well, was just testing it before I commented lol I'm adding it to our server pack now, feels good to finally have the player detector - been DYING to build with that 😁

SamsTheNerd commented 1 year ago

also not super related to this issue but if you're gonna have hex, hexal and moreIotas are some great addons for it

MAGGen-hub commented 1 year ago

oh i see, focal port only gets registered when hex casting is installed.

I'll look into the best way to fix that in the next release but if you want a quick fix you can install hex casting (with the bonus that you get another cool mod to play with lol)

Eh, sorry but... It's not a good solution for a create mod based modpack with 270+ mods.... I already have Eden Ring mod that can be used as infinite overpowered source of metal ores. If I install Hex Casting... My modpack may lose the last pieces of logic, balance, and stability.

I will try it but... Well... Hope I will not crash on the start...

MAGGen-hub commented 1 year ago

I think removing ducky-periphs:focal_port_block from minecraft:mineable/pickaxe may be better solution for persons who don't use Hex Casting... At last it worked for me...

{
    "replace": false,
    "values": [
        "ducky-periphs:weather_machine_block",
        "ducky-periphs:entity_detector_block",
        "ducky-periphs:sculkophone_block"
    ]
  }
MAGGen-hub commented 1 year ago

I am not very good at modding but... Well gues it imposible to make "dunamic" compatability tag for focal port block with a datapack... I saw something like /data/*yourmod*/compatdata/*compatmod*/minecraft/tags/blocks/minable/pickaxe.json but it was on 1.12.2 with some lib usage and on forge...

I think you need to make it minable, by java code, unfortunately...

SamsTheNerd commented 1 year ago

yeah, either that or register a dummy focal port block if hexcasting isn't installed so it doesn't error out. I think the dummy block method would be better but idk, i'll look into it again after I do the architectury rework.

SamsTheNerd commented 1 year ago

should be fixed in v1.2.0

dnk1234567 commented 4 months ago

This bug can be reproduce on 1.20.1 by minimal environment. Mods list: duckyperiphs-1.20.1-1.3.1-forge hexcasting-forge-1.20.1-0.11.1-7-pre-620 Forge 47.2.6

Installed the mod(Observer is just an example): 2024-03-08_23 02 49

Deleted the mod(Hex Casting is still on): 2024-03-08_23 03 51

The #minecraft:mineable/pickaxe will missing if both mods are on.