search

Samsung / Castanets

Edge distributed web engine. Part of web engine processes are offloaded to a powerful devices and only graphical results are processed in local devices. This way, we overcome both CPU limitations and memory limitations of the low-end local devices
BSD 3-Clause "New" or "Revised" License
45 stars 43 forks source link

Add support of run time flags for enable Castanets #318

Closed santhoshkerur closed 4 years ago

santhoshkerur commented 4 years ago

This change adds runtime flag to enable castanets. Runtime flags --enable-forking, --server-address has been removed. Castanets can be verified as below,

Standalone mode: chrome

Castanets mode: Browser: chrome --enable-castanets Renderer: chrome --type=renderer --enable-castanets=

Signed-off-by: Santhoshkumar Kerur santhosh.vk@samsung.com Signed-off-by: suyambu.rm suyambu.rm@samsung.com

santhoshkerur commented 4 years ago

There are many changes specific to ANDROID and CASTANETS in below files.. We need to cross check if runtime checks are needed for those too.

gpu/ipc/common/gpu_memory_buffer_support.cc gpu/ipc/service/gpu_memory_buffer_factory.cc ui/gfx/mojo/buffer_types_struct_traits.cc content/browser/frame_host/frame_tree_node.cc content/browser/frame_host/render_frame_host_impl.cc content/browser/android/content_startup_flags.cc content/browser/child_process_launcher_helper_android.cc content/public/browser/content_browser_client.cc content/public/common/use_zoom_for_dsf_policy.cc content/public/common/content_features.cc content/renderer/render_widget.cc content/renderer/input/render_widget_input_handler.cc third_party/blink/renderer/core/loader/resource/script_resource.cc third_party/blink/public/common/page/launching_process_state.h mojo/public/cpp/system/platform_handle.cc mojo/core/platform_handle_utils.cc mojo/core/broker_castanets.cc mojo/core/core.cc mojo/core/broker_host.cc mojo/core/shared_buffer_dispatcher.cc

@suyambulingamrm , Files have changed. Thanks for review and Support as co-contributor.

suyambulingamrm commented 4 years ago

+1. Verified on desktop, android. Below are not part of this patch yet.

  1. Minimise castanets main activity only when --enable-castanets is provided. (Inprogress will be part of new patchset)
  2. We were using BGRA as Skia format for castanets to make android renderer compatible with chrome/efl browser. Because of this we see incorrect colors on some pages, when we run android browser without runtime flag. (TODO)
suyambulingamrm commented 4 years ago

I commented about duplicate codes, but it is not critical.

Done.