Add Peer review function to dexter-vs

Samsung / Dexter

Dexter is a static analysis platform to find and remove defects efficiently and immediately during the coding-time.

BSD 2-Clause "Simplified" License

56 stars 33 forks source link

Closed mdopark closed 7 years ago

mdopark commented 7 years ago

Change previous project name 'dexter-vs' to 'Dexter.Core'
Change folder trees and namespaces of 'dexter-vs' project
Add new project 'Dexter.Common.Core' for common codes and move some config/provider/utils codes into 'Dexter.Common.Core' from 'Dexter.Core'
Add new project 'Dexter.PeerReivew.Core' for the peer review function
Add 'enableDexterHomeCheckBox' control in Setting page to support c# source codes

mdopark commented 7 years ago

@KarolAntczak Hi, Karol. Could you review it and check whether previous functions do work correctly?

KarolAntczak commented 7 years ago

Hi @mdopark,

Physical location of some classes (e.g. ConfigurationTest) is inconsistent with their namespaces. Please fix it.
There are missing documentation comments in public classes.
Please check spelling, e.g. PeerReivew -> PeerReview. Also, I would advise not to use abbreviations, i.e. PReviewGlyphFactoryTest -> PeerReviewGlyphFactoryTest
Dexter.Common.Tests should be a test project. Now it is recognized by Visual Studio as a regular project

Min-Ho-Kim commented 7 years ago

Thank you! Spark by Readdle

KarolAntczak commented 7 years ago

There is a problem with 'Newtonsoft.Json''library. It seems that it couldn't be found by VS:

As a result, project is not building properly.

mdopark commented 7 years ago

@KarolAntczak I updated nuget packages and checked build success after clean sources downloaded. Please try to build with latest changes.

KarolAntczak commented 7 years ago

It builds now, thank you. Also, all functions work correctly.