search

Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.
http://www.gearvrf.org
Apache License 2.0
407 stars 217 forks source link

X3D DEF/USE for IndexedFaceSet causing null pointer, crash #1516

Closed mwitchwilliams closed 7 years ago

mwitchwilliams commented 7 years ago

New master (v 4.0), IndexedFaceSet DEF/USE causing null pointer. Was working in maint_v3.x

When parsing Inside X3Dobject, SAX parser end command has gvrVertexBuffer null. About line 3630 in the code

Test found in our Tests repo -> x3d -> Scripting_Per_Frame -> JavaScript_PerFrame_02_LaunchSphere.x3d

https://github.com/gearvrf/GearVRf-Tests/blob/master/x3d/Scripting_Per_Frame/JavaScript_PerFrame_02_LaunchSphere.x3d

Same issue with test case JavaScript_PerFrame_05_LightControls.x3d found in the same repo directory.

mwitchwilliams commented 7 years ago

Fixed with Pull Request https://github.com/Samsung/GearVRf/pull/1527